Skip to content

Raise on ruby 2.7 deprecation warnings#3913

Merged
feelepxyz merged 2 commits intomainfrom
feelepxyz/raise-on-warnings
Jun 16, 2021
Merged

Raise on ruby 2.7 deprecation warnings#3913
feelepxyz merged 2 commits intomainfrom
feelepxyz/raise-on-warnings

Conversation

@feelepxyz
Copy link
Copy Markdown
Contributor

Break tests if we introduce any ruby 2.7 deprecation warnings.

@feelepxyz feelepxyz requested a review from a team as a code owner June 16, 2021 09:15
Copy link
Copy Markdown
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (I guess we're expecting this to fail for a bit and still need to clean a few things up?)

We might need to allow some warnings, not all will be ruby 2.7 related?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@feelepxyz feelepxyz force-pushed the feelepxyz/raise-on-warnings branch 2 times, most recently from e3473c6 to 84aa0e8 Compare June 16, 2021 10:33
Break tests if we introduce any ruby 2.7 deprecation warnings.
@feelepxyz feelepxyz force-pushed the feelepxyz/raise-on-warnings branch from 84aa0e8 to 969443e Compare June 16, 2021 10:49
@feelepxyz feelepxyz merged commit a16d67b into main Jun 16, 2021
@feelepxyz feelepxyz deleted the feelepxyz/raise-on-warnings branch June 16, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants